-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nx-cugraph: add more shortest path algorithms #4199
nx-cugraph: add more shortest path algorithms #4199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I did have a few comments and questions which need not hold up approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I have a couple comments but nothing worth slowing it down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to explain the basic way cuGraph runs these algos. How the "conversions" are or are not done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes permissions to be executable
/merge |
This begins by adding more unweighted shortest path algorithms. Next we'll do weighted via
sssp
, then generic.Note that there are some performance improvements that can be made:
bidirectional_shortest_path
andhas_path
bfs
fromsource
untiltarget
is reachedall_pairs*
in batched groups